Scan Tailor "Experimental"

Scan Tailor specific announcements, releases, workflows, tips, etc. NO FEATURE REQUESTS IN THIS FORUM, please.

Moderator: peterZ

Tulon
Posts: 687
Joined: 03 Oct 2009, 06:13
Number of books owned: 0
Location: London, UK
Contact:

Re: Scan Tailor "Experimental"

Post by Tulon »

d14b0ll0s wrote: We're making progress -- stopped at 12% ;)
Fixed this one as well.
Scan Tailor experimental doesn't output 96 DPI images. It's just what your software shows when DPI information is missing. Usually what you get is input DPI times the resolution enhancement factor.
d14b0ll0s
Posts: 31
Joined: 17 Aug 2015, 19:37
Number of books owned: 3000
Country: Poland

Re: Scan Tailor "Experimental"

Post by d14b0ll0s »

Tulon wrote:Fixed this one as well.
Another one:

Code: Select all

[ 18%] Building CXX object filters/page_split/CMakeFiles/page_split.dir/Filter.cpp.o
/Users/sirat/Downloads/scantailor-EXPERIMENTAL_2015_08_20/filters/page_split/Filter.cpp:113:43: error: 
      reference to '_1' is ambiguous
                        this, boost::ref(doc), var(filter_el), _1, _2
                                                               ^
/opt/local/include/boost/lambda/core.hpp:69:37: note: candidate found by name lookup is
      'boost::lambda::(anonymous namespace)::_1'
  boost::lambda::placeholder1_type& _1 = free1;
                                    ^
/opt/local/include/boost/bind/placeholders.hpp:55:15: note: candidate found by name lookup is
      '(anonymous namespace)::_1'
boost::arg<1> _1;
              ^
/Users/sirat/Downloads/scantailor-EXPERIMENTAL_2015_08_20/filters/page_split/Filter.cpp:113:47: error: 
      reference to '_2' is ambiguous
                        this, boost::ref(doc), var(filter_el), _1, _2
                                                                   ^
/opt/local/include/boost/lambda/core.hpp:70:37: note: candidate found by name lookup is
      'boost::lambda::(anonymous namespace)::_2'
  boost::lambda::placeholder2_type& _2 = free2;
                                    ^
/opt/local/include/boost/bind/placeholders.hpp:56:15: note: candidate found by name lookup is
      '(anonymous namespace)::_2'
boost::arg<2> _2;
              ^
2 errors generated.
make[2]: *** [filters/page_split/CMakeFiles/page_split.dir/Filter.cpp.o] Error 1
make[1]: *** [filters/page_split/CMakeFiles/page_split.dir/all] Error 2
make: *** [all] Error 2
Tulon
Posts: 687
Joined: 03 Oct 2009, 06:13
Number of books owned: 0
Location: London, UK
Contact:

Re: Scan Tailor "Experimental"

Post by Tulon »

Fixed those as well.
Scan Tailor experimental doesn't output 96 DPI images. It's just what your software shows when DPI information is missing. Usually what you get is input DPI times the resolution enhancement factor.
VipeRsan
Posts: 5
Joined: 23 Jan 2013, 12:55
E-book readers owned: Kindle 3
Number of books owned: 50
Country: Poland

Re: Scan Tailor "Experimental"

Post by VipeRsan »

Great work Tulon.

One suggestion: can you return to mm/inch in tab margins? With percentage scale i can't properly align pages :(
d14b0ll0s
Posts: 31
Joined: 17 Aug 2015, 19:37
Number of books owned: 3000
Country: Poland

Re: Scan Tailor "Experimental"

Post by d14b0ll0s »

Tulon wrote:Fixed those as well.
Something's missing later on:

Code: Select all

[ 33%] Building CXX object imageproc/CMakeFiles/imageproc.dir/WienerFilter.cpp.o
/Users/sirat/Downloads/scantailor-experimental/imageproc/WienerFilter.cpp:102:59: error: 
      no member named 'lround' in namespace 'std'
                image_line[x] = static_cast<uint8_t>(std::lround(dst_pixel));
                                                     ~~~~~^
1 error generated.
Tulon
Posts: 687
Joined: 03 Oct 2009, 06:13
Number of books owned: 0
Location: London, UK
Contact:

Re: Scan Tailor "Experimental"

Post by Tulon »

VipeRsan wrote:Great work Tulon.

One suggestion: can you return to mm/inch in tab margins? With percentage scale i can't properly align pages :(
Can't do. Because ST no longer asks users to correct DPIs, it can no longer map between physical units and pixels.
Scan Tailor experimental doesn't output 96 DPI images. It's just what your software shows when DPI information is missing. Usually what you get is input DPI times the resolution enhancement factor.
Tulon
Posts: 687
Joined: 03 Oct 2009, 06:13
Number of books owned: 0
Location: London, UK
Contact:

Re: Scan Tailor "Experimental"

Post by Tulon »

d14b0ll0s wrote:
Tulon wrote:Fixed those as well.
Something's missing later on:

Code: Select all

[ 33%] Building CXX object imageproc/CMakeFiles/imageproc.dir/WienerFilter.cpp.o
/Users/sirat/Downloads/scantailor-experimental/imageproc/WienerFilter.cpp:102:59: error: 
      no member named 'lround' in namespace 'std'
                image_line[x] = static_cast<uint8_t>(std::lround(dst_pixel));
                                                     ~~~~~^
1 error generated.
Fixed.
Scan Tailor experimental doesn't output 96 DPI images. It's just what your software shows when DPI information is missing. Usually what you get is input DPI times the resolution enhancement factor.
d14b0ll0s
Posts: 31
Joined: 17 Aug 2015, 19:37
Number of books owned: 3000
Country: Poland

Re: Scan Tailor "Experimental"

Post by d14b0ll0s »

Tulon wrote:Fixed.
We're getting there. :)
A warning first:

Code: Select all

[ 82%] Building CXX object CMakeFiles/scantailor-cli.dir/ConsoleBatch.cpp.o
/Users/sirat/Downloads/scantailor-experimental/ConsoleBatch.cpp:199:9: warning: 
      comparison of unsigned expression < 0 is always false
      [-Wtautological-compare]
                if (sf<0 || sf>=m_ptrStages->filters().size())
                    ~~^~
/Users/sirat/Downloads/scantailor-experimental/ConsoleBatch.cpp:208:9: warning: 
      comparison of unsigned expression < 0 is always false
      [-Wtautological-compare]
                if (ef<0 || ef>=m_ptrStages->filters().size())
                    ~~^~
2 warnings generated.
...and an error soon after:

Code: Select all

[ 86%] Building CXX object imageproc/tests/CMakeFiles/imageproc_tests.dir/TestGaussBlur.cpp.o
/Users/sirat/Downloads/scantailor-experimental/imageproc/tests/TestGaussBlur.cpp:204:55: error: 
      invalid operands to binary expression ('const char *' and 'double')
        BOOST_MESSAGE("Anisotropic Gauss blur RMSE: mean = " << mean_rmse << ", ...
                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~
1 error generated.
make[2]: *** [imageproc/tests/CMakeFiles/imageproc_tests.dir/TestGaussBlur.cpp.o] Error 1
make[1]: *** [imageproc/tests/CMakeFiles/imageproc_tests.dir/all] Error 2
make: *** [all] Error 2
VipeRsan
Posts: 5
Joined: 23 Jan 2013, 12:55
E-book readers owned: Kindle 3
Number of books owned: 50
Country: Poland

Re: Scan Tailor "Experimental"

Post by VipeRsan »

Tulon wrote:Can't do. Because ST no longer asks users to correct DPIs, it can no longer map between physical units and pixels.
Then maybe in pixels? It should better to align pages with constant amount of pixels than calculate based on percentage.

EDIT:
Also it would be good to use canvas size adapted to the standard ratio of A4, A5, B4, B5, letter, custom, etc. It can be done based on simple proportion to calculate amount of pixels in x and y direction.
Tulon
Posts: 687
Joined: 03 Oct 2009, 06:13
Number of books owned: 0
Location: London, UK
Contact:

Re: Scan Tailor "Experimental"

Post by Tulon »

d14b0ll0s wrote:

Code: Select all

[ 86%] Building CXX object imageproc/tests/CMakeFiles/imageproc_tests.dir/TestGaussBlur.cpp.o
/Users/sirat/Downloads/scantailor-experimental/imageproc/tests/TestGaussBlur.cpp:204:55: error: 
      invalid operands to binary expression ('const char *' and 'double')
        BOOST_MESSAGE("Anisotropic Gauss blur RMSE: mean = " << mean_rmse << ", ...
                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~
1 error generated.
make[2]: *** [imageproc/tests/CMakeFiles/imageproc_tests.dir/TestGaussBlur.cpp.o] Error 1
make[1]: *** [imageproc/tests/CMakeFiles/imageproc_tests.dir/all] Error 2
make: *** [all] Error 2
Fixed.
Scan Tailor experimental doesn't output 96 DPI images. It's just what your software shows when DPI information is missing. Usually what you get is input DPI times the resolution enhancement factor.
Post Reply